Re: [PATCH 1/1] x86/platform/intel-mid: convert to use i2c_new_client_device()

[Andy Shevchenko]

On Thu, Mar 26, 2020 at 11:10 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>  arch/x86/platform/intel-mid/sfi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c
> index b8f7f193f383..30bd5714a3d4 100644
> --- a/arch/x86/platform/intel-mid/sfi.c
> +++ b/arch/x86/platform/intel-mid/sfi.c
> @@ -287,8 +287,8 @@ void intel_scu_devices_create(void)
>
>                 adapter = i2c_get_adapter(i2c_bus[i]);
>                 if (adapter) {
> -                       client = i2c_new_device(adapter, i2c_devs[i]);
> -                       if (!client)
> +                       client = i2c_new_client_device(adapter, i2c_devs[i]);
> +                       if (IS_ERR(client))
>                                 pr_err("can't create i2c device %s\n",
>                                         i2c_devs[i]->type);
>                 } else
> --
> 2.20.1
>


-- 
With Best Regards,
Andy Shevchenko