Re: [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for Intel Xeon server platform

[Alexander Shishkin]

roman.sudarikov@xxxxxxxxxxxxxxx writes:

> ---
>  .../ABI/testing/sysfs-devices-mapping         |  33 +++
>  arch/x86/events/intel/uncore.h                |   9 +
>  arch/x86/events/intel/uncore_snbep.c          | 191 ++++++++++++++++++
>  3 files changed, 233 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-devices-mapping
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-mapping b/Documentation/ABI/testing/sysfs-devices-mapping
> new file mode 100644
> index 000000000000..16f4e900be7b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-mapping

Is this a good place for something that's perf/x86/intel/uncore
specific?

> +                Which means:
> +                IIO PMU 0 on die 0 belongs to PCI RP on bus 0x00, domain 0x0000
> +                IIO PMU 0 on die 1 belongs to PCI RP on bus 0x40, domain 0x0000
> +                IIO PMU 0 on die 2 belongs to PCI RP on bus 0x80, domain 0x0000
> +                IIO PMU 0 on die 3 belongs to PCI RP on bus 0xc0, domain 0x0000
> \ No newline at end of file

Git is trying to tell you something.

> +		eas[die].attr.attr.mode = 0444;

I believe this one is also known as S_IRUGO.

Other than that, this patch is

Reviewed-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

Regards,
--
Alex