RE: [PATCH v2 2/2] scsi: ufs-mediatek: add error recovery for suspend and resume

[Stanley Chu]

Hi Avri,

On Fri, 2020-03-27 at 09:23 +0000, Avri Altman wrote:
> > 
> > Once fail happens during suspend and resume flow if the desired low
> > power link state is H8, link recovery is required for MediaTek UFS
> > controller.
> > 
> > For resume flow, since power and clocks are already enabled before
> > invoking vendor's resume callback, simply using ufshcd_link_recovery()
> > inside callback is fine.
> > 
> > For suspend flow, the device power enters low power mode or is disabled
> > before suspend callback, thus ufshcd_link_recovery() can not be directly
> > used in callback. To leverage host reset flow during ufshcd_suspend(),
> > set link as off state enforcedly 
> Not sure this is a proper English, but I'm not sure.
> 
> to let ufshcd_host_reset_and_restore()
> > be executed by ufshcd_suspend().

Thanks for your review! I will fix this sentence in next version.

Stanley Chu