Re: [PATCH v2] irqchip/versatile-fpga: Handle chained IRQs properly

[Linus Walleij]

On Thu, Mar 19, 2020 at 3:36 AM Sungbo Eo <mans0n@xxxxxxxxxx> wrote:

> Enclose the chained handler with chained_irq_{enter,exit}(), so that the
> muxed interrupts get properly acked.
>
> This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer
> interrupt is never acked. The kernel waits a clock tick forever in
> calibrate_delay_converge(), which leads to a boot hang.
>
> Fixes: c41b16f8c9d9 ("ARM: integrator/versatile: consolidate FPGA IRQ handling code")
> Signed-off-by: Sungbo Eo <mans0n@xxxxxxxxxx>
> Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> v2: moved readl below chained_irq_enter()
>     added Fixes tag

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I wonder how Integrator keeps working so well despite
this. I can't test it right now but I'm sure it is fine.

Yours,
Linus Walleij