On Fri, Mar 27, 2020 at 10:14:10AM +0100, Lars-Peter Clausen wrote:
On 3/27/20 9:43 AM, Michael Grzeschik wrote:OK, can you give me an Userspace example how to simply trigger the
dwc3_gadget_ep_disable gets called before the last request gets
dequeued.
In __dwc3_gadget_ep_disable all started, pending and cancelled
lists for this endpoint will call dwc3_gadget_giveback in
dwc3_remove_requests.
After that no list containing the afterwards dequed request,
therefor it is not necessary to run the dequeue routine.
Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
---
@Lars-Peter Clausen:
This patch addresses the case that not queued requests get dequeued.
The only case that this happens seems on disabling the gadget.
I don't believe it does. Calling usb_ep_dequeue() is not limited to be
called after the endpoint has been disabled. It is part of the API and can
be called at any time. E.g. with function_fs you can abort a queued transfer
from userspace at any time.
issue. I tried to figure your mentioned function stack but it would
be much easier if it could be reproduced.
The patch on the other hand can stand on itself, as it then
fixes another code path that is much more common.