Re: [PATCH] iommu: Lower severity of add/remove device messages
From: Ezequiel Garcia
Date: Fri Mar 27 2020 - 09:02:22 EST
Hello Joerg,
Thanks for reviewing.
I understand this change bears some controversy
for IOMMU, as developers are probably used to see these
messages.
On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote:
> On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
> > These user messages are not really informational,
> > but mostly of debug nature. Lower their severity.
>
> Like most other messages in the kernel log, that is not a reason to
> lower the severity.
>
> These messages are the first thing to look at when
> looking into IOMMU related issues.
>
Sure, but the messages are still here, you can
always enable them when you are looking at IOMMU issues :-)
The idea is to reduce the amount of verbosity in the kernel.
If all subsystems would print messages that are useful
when looking at issues, things would be quite nasty verbose.
Thanks!
Ezequiel