Re: [PATCH v4 5/8] usb: mausb_host: Introduce PAL processing

From: Alan Stern
Date: Fri Mar 27 2020 - 12:36:01 EST


On Fri, 27 Mar 2020 vladimir.stankovic@xxxxxxxxxxxxxxx wrote:

> Protocol adaptation layer (PAL) implementation has been added to
> introduce MA-USB structures and logic.
>
> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@xxxxxxxxxxxxxxx>
> ---
> + /*
> + * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
> + * should not, so it is breaking the USB drive on the linux
> + */
> + urb->transfer_flags &= ~URB_SHORT_NOT_OK;

Please explain more fully. What SCSI driver are you talking about?
Where is the flag getting added incorrectly? What USB drive is getting
broken, and how?

If there's a bug in a SCSI driver, why don't you report it and get it
fixed instead of trying to create a workaround in just one host
controller driver?

Alan Stern