Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus

[Matthias Brugger]

On 27/03/2020 17:17, Florian Fainelli wrote:
> 
> 
> On 3/27/2020 9:15 AM, Matthias Brugger wrote:
>>
>>
>> On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
>>> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
>>> firmware bus DMA limitations") the firmware bus has to comply with
>>> /soc's DMA limitations. Ultimately linking both buses to a same
>>> dma-ranges property. The patch (and author) missed the fact that a bus'
>>> #address-cells and #size-cells properties are not inherited, but set to
>>> a fixed value which, in this case, doesn't match /soc's. This, although
>>> not breaking Linux's DMA mapping functionality, generates ugly dtc
>>> warnings.
>>>
>>> Fix the issue by adding the correct address and size cells properties
>>> under the firmware bus.
>>>
>>> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
>>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
>>
>> Reviewed-by: Matthias Brugger <mbrugger@xxxxxxxx>
> 
> Should this be squashed into "ARM: dts: bcm283x: Fix vc4's firmware bus
> DMA limitations"? I have not gotten a response it has been accepted yet.
> 

Well I think if we can squash the two instead of providing a Fixes-tag, even better.

Regards,
Matthias