RE: [PATCH v1 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs

[Kammela, Gayatri]

> -----Original Message-----
> From: Pandruvada, Srinivas <srinivas.pandruvada@xxxxxxxxx>
> Sent: Friday, March 27, 2020 1:37 PM
> To: linux-pm@xxxxxxxxxxxxxxx; Kammela, Gayatri
> <gayatri.kammela@xxxxxxxxx>
> Cc: dvhart@xxxxxxxxxxxxx; alex.hung@xxxxxxxxxxxxx;
> daniel.lezcano@xxxxxxxxxx; amit.kucheria@xxxxxxxxxxxxx; lenb@xxxxxxxxxx;
> peterz@xxxxxxxxxxxxx; Zhang, Rui <rui.zhang@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; Westerberg,
> Mika <mika.westerberg@xxxxxxxxx>; Prestopine, Charles D
> <charles.d.prestopine@xxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx;
> Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>
> Subject: Re: [PATCH v1 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
> 
> On Fri, 2020-03-27 at 13:24 -0700, Gayatri Kammela wrote:
> > Tiger Lake's new unique ACPI device IDs for DPTF and fan drivers are
> > not valid as the IDs are missing 'C'. Fix the IDs by updating them.
> >
> > After the update, the new IDs should now look like
> > INT1047 --> INTC1047
> > INT1040 --> INTC1040
> > INT1043 --> INTC1043
> > INT1044 --> INTC1044
> >
> We need Fixes tag.
> 
> For example
> 
> Fixes: 55cfe6a5c582 ("ACPI: DPTF: Add Tiger Lake ACPI device IDs")
> Cc: 5.6+ <stable@xxxxxxxxxxxxxxx> # 5.6+

Thanks Srinivas! I will add the fixes tag and send v2

> 
> By the time this patch is merged I guess the 5.6 will be out.
> 
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxx>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxx>
> > Signed-off-by: Gayatri Kammela <gayatri.kammela@xxxxxxxxx>
> > ---
> >  drivers/acpi/device_pm.c            | 2 +-
> >  drivers/acpi/dptf/dptf_power.c      | 2 +-
> >  drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
> >  3 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index
> > b64c62bfcea5..80dae3b3c36a 100644
> > --- a/drivers/acpi/device_pm.c
> > +++ b/drivers/acpi/device_pm.c
> > @@ -1321,7 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool
> > power_on)
> >  	 */
> >  	static const struct acpi_device_id special_pm_ids[] = {
> >  		{"PNP0C0B", }, /* Generic ACPI fan */
> > -		{"INT1044", }, /* Fan for Tiger Lake generation */
> > +		{"INTC1044", }, /* Fan for Tiger Lake generation */
> >  		{"INT3404", }, /* Fan */
> >  		{}
> >  	};
> > diff --git a/drivers/acpi/dptf/dptf_power.c
> > b/drivers/acpi/dptf/dptf_power.c index 387f27ef3368..e5fb34bfa52c
> > 100644
> > --- a/drivers/acpi/dptf/dptf_power.c
> > +++ b/drivers/acpi/dptf/dptf_power.c
> > @@ -97,7 +97,7 @@ static int dptf_power_remove(struct platform_device
> > *pdev)
> >  }
> >
> >  static const struct acpi_device_id int3407_device_ids[] = {
> > -	{"INT1047", 0},
> > +	{"INTC1047", 0},
> >  	{"INT3407", 0},
> >  	{"", 0},
> >  };
> > diff --git a/drivers/acpi/dptf/int340x_thermal.c
> > b/drivers/acpi/dptf/int340x_thermal.c
> > index 1ec7b6900662..29b5c77256dd 100644
> > --- a/drivers/acpi/dptf/int340x_thermal.c
> > +++ b/drivers/acpi/dptf/int340x_thermal.c
> > @@ -13,10 +13,10 @@
> >
> >  #define INT3401_DEVICE 0X01
> >  static const struct acpi_device_id int340x_thermal_device_ids[] = {
> > -	{"INT1040"},
> > -	{"INT1043"},
> > -	{"INT1044"},
> > -	{"INT1047"},
> > +	{"INTC1040"},
> > +	{"INTC1043"},
> > +	{"INTC1044"},
> > +	{"INTC1047"},
> >  	{"INT3400"},
> >  	{"INT3401", INT3401_DEVICE},
> >  	{"INT3402"},