Re: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

From: Adam Ford
Date: Fri Mar 27 2020 - 23:47:53 EST


On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <horia.geanta@xxxxxxx> wrote:
>
> On 2/25/2020 6:12 PM, Andrà Draszik wrote:
> > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
> >
> > This driver here should only return IRQ_HANDLED if the status register
> > indicates that the event we're handling in the irq handler was genuinely
> > intended for this driver. Otheriwse the interrupt subsystem will
> > assume the interrupt was handled successfully even though it wasn't
> > at all.
> >
> > Signed-off-by: Andrà Draszik <git@xxxxxxxxxx>
> > Cc: "Horia GeantÄ" <horia.geanta@xxxxxxx>
> > Cc: Aymen Sghaier <aymen.sghaier@xxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > Cc: NXP Linux Team <linux-imx@xxxxxxx>
> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > Cc: Anson Huang <Anson.Huang@xxxxxxx>
> > Cc: Robin Gong <yibin.gong@xxxxxxx>
> > Cc: linux-crypto@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: linux-input@xxxxxxxxxxxxxxx
> For patches 2-6:
> Reviewed-by: Horia GeantÄ <horia.geanta@xxxxxxx>
>
> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated.

Is there an update coming for the 8mn family? I am seeing it not wake
from the power key, and I was hoping to resolve that before i make a
push to submit a new 8MN board for review.

thanks

adam
>
> Thanks,
> Horia
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel