Re: [PATCH] ext4: Fix incorrect inodes per group in error message

[Andreas Dilger]

On Mar 28, 2020, at 4:34 PM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> 
> If ext4_fill_super detects an invalid number of inodes per group, the
> resulting error message printed the number of blocks per group, rather
> than the number of inodes per group. Fix it to print the correct value.
> 
> Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount")

LGTM

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0c7c4adb664e..c50922fa780a 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4157,7 +4157,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> 	if (sbi->s_inodes_per_group < sbi->s_inodes_per_block ||
> 	    sbi->s_inodes_per_group > blocksize * 8) {
> 		ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n",
> -			 sbi->s_blocks_per_group);
> +			 sbi->s_inodes_per_group);
> 		goto failed_mount;
> 	}
> 	sbi->s_itb_per_group = sbi->s_inodes_per_group /
> --
> 2.26.0
> 


Cheers, Andreas

Attachment: signature.asc
Description: Message signed with OpenPGP