Re: [PATCH v2 06/14] usb: dwc3: meson-g12a: refactor usb2 phy init

[Felipe Balbi]

Hi,

Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> writes:

> Hi Neil,
>
> On Thu, Mar 26, 2020 at 2:45 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> Refactor the USB2 PHY init code patch to handle the Amlogic GXL/GXM
>> not having the PHY mode control registers in the Glue but in the PHY
>> registers.
>>
>> The Amlogic GXL/GXM will call phy_set_mode() instead of programming the
>> PHY mode control registers, thus add two new callbacks to the SoC match
>> data.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> checkpatch reports that five lines need to be checked.
> these all look valid (for example: "Alignment should match open parenthesis")
>
> with these addressed:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

That's a CHECK, only shows with --strict. drivers/usb/ ignores those for
the most part.

-- 
balbi

Attachment: signature.asc
Description: PGP signature