Re: [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger
From: Andy Shevchenko
Date: Sun Mar 29 2020 - 07:17:59 EST
On Sun, Mar 29, 2020 at 1:34 PM saravanan sekar <sravanhome@xxxxxxxxx> wrote:
> On 28/03/20 7:44 pm, Andy Shevchenko wrote:
> > On Sat, Mar 28, 2020 at 1:29 PM saravanan sekar <sravanhome@xxxxxxxxx> wrote:
> >> On 28/03/20 12:02 pm, Andy Shevchenko wrote:
> >>> On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@xxxxxxxxx> wrote:
...
> >>>> + struct power_supply_config psy_cfg = {NULL};
> >>> { 0 }
> >>>
> >> NULL to make compiler happy.
> > Hmm... Can you share warning / error compiler issued in 0 case?
> >
> Please see the 0-day warning.
>
> "Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/power/supply/mp2629_charger.c:584:47: sparse: sparse: Using
> plain integer as NULL pointer"
I see. Grepping the code shows that for this certain structure other
drivers are using simple '{}'. Can you align with them?
--
With Best Regards,
Andy Shevchenko