Re: [PATCH] ext4: Fix incorrect group count in ext4_fill_super error message
From: Theodore Y. Ts'o
Date: Sun Mar 29 2020 - 12:45:05 EST
On Sat, Mar 28, 2020 at 10:36:07PM -0600, Andreas Dilger wrote:
> You missed the v2 patch, which was better IMHO.
I saw the V2 patch, but the it will print the 32-bit truncated block
count, and it's possible if things are really insane, the number of
block groups calculated will be > 2**32. In which case the V1 patch
with the format string adjusted will print a less confusing message.
e.g.:
groups count too large: 8589934634 ....
as opposed to:
groups count too large: 42 ....
- Ted