Re: [PATCH 4/6] soc: bt1: Add Baikal-T1 AXI-bus EHB driver

[Randy Dunlap]

Hi--

On 3/6/20 5:07 AM, Sergey.Semin@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> 
> AXI3-bus is the main communication bus connecting all high-speed peripheral
> IP-cores with RAM controller and MIPS P5600 cores. Baikal-T1 SoC provides a
> way to detect the bus protocol errors and report a short info about it by
> means of the AXI-bus Errors Handler Block (AXI EHB). The block rises an

                                                                 raises an

> interrupt indicating an AXI protocol error at an attempt either to reach
> a non-existent slave device or to perform an invalid operation with a
> slave IP-block. This driver provides the interrupt handler, which prints
> an error message with a faulty address and updates an errors counter,
> and exposes a sysfs-node to inject the described types of errors.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Cc: Paul Burton <paulburton@xxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Olof Johansson <olof@xxxxxxxxx>
> Cc: soc@xxxxxxxxxx
> ---

> diff --git a/drivers/soc/baikal-t1/Kconfig b/drivers/soc/baikal-t1/Kconfig
> new file mode 100644
> index 000000000000..aca155350612
> --- /dev/null
> +++ b/drivers/soc/baikal-t1/Kconfig
> @@ -0,0 +1,22 @@
> +# SPDX-License-Identifier: GPL-2.0
> +menu "Baikal-T1 SoC drivers"
> +
> +config SOC_BAIKAL_T1
> +	def_bool y
> +	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> +
> +config BT1_AXI_EHB
> +	bool "Baikal-T1 AXI-bus Errors Handler Block"
> +	depends on SOC_BAIKAL_T1 && OF
> +	help
> +	  Baikal-T1 CCU registers space as being MFD provides an access to the

	                                             and provides access to the

> +	  AXI-bus Errors Handler Block (AXI EHB). It rises an interrupt

	                                             raises

> +	  indicating an AXI protocol error at an attempt either to reach a
> +	  non-existent slave device or to perform an invalid operation with a
> +	  slave IP-block. This driver provides the interrupt handler, which
> +	  prints an error message with a faulty address and updates an errors
> +	  counter.
> +
> +	  If unsure, say N.
> +
> +endmenu

-- 
~Randy