Re: [PATCH v9 13/55] Input: atmel_mxt_ts - add regulator control support

[Wang, Jiada]

Hi Dmitry

On 2020/03/30 3:54, Dmitry Osipenko wrote:
> 27.03.2020 14:09, Wang, Jiada ÐÐÑÐÑ:
> > Hi Dmitry
> >
> > On 2020/03/26 4:05, Dmitry Osipenko wrote:
> > > 25.03.2020 16:32, Jiada Wang ÐÐÑÐÑ:
> > > > From: Nick Dyer <nick.dyer@xxxxxxxxxxx>
> > > >
> > > > Allow the driver to optionally manage enabling/disable power to the
> > > > touch
> > > > controller itself. If the regulators are not present then use the deep
> > > > sleep power mode instead.
> > > >
> > > > For a correct power on sequence, it is required that we have control
> > > > over
> > > > the RESET line.
> > >
> > > ...
> > > > +ÂÂÂ data->reg_vdd = devm_regulator_get(dev, "vdd");
> > > > +ÂÂÂ if (IS_ERR(data->reg_vdd)) {
> > > > +ÂÂÂÂÂÂÂ error = PTR_ERR(data->reg_vdd);
> > > > +ÂÂÂÂÂÂÂ dev_err(dev, "Error %d getting vdd regulator\n", error);
> > > > +ÂÂÂÂÂÂÂ goto fail;
> > > > +ÂÂÂ }
> > > > +
> > > > +ÂÂÂ data->reg_avdd = devm_regulator_get(dev, "avdd");
> > > > +ÂÂÂ if (IS_ERR(data->reg_avdd)) {
> > > > +ÂÂÂÂÂÂÂ error = PTR_ERR(data->reg_avdd);
> > > > +ÂÂÂÂÂÂÂ dev_err(dev, "Error %d getting avdd regulator\n", error);
> > > > +ÂÂÂÂÂÂÂ goto fail_release;
> > > > +ÂÂÂ }
> > >
> > > Hello Jiada,
> > >
> > > The new regulator properties should be documented in the device-tree
> > > binding.
> > I will document new regulator properties in a separate commit in
> > v10 patch-set
>
> Please make sure that all patches are added in a correct order and that
> they at least compile. This patch doesn't compile:
Sure, I will take care of this issue in next version

Thanks,
Jiada
>    CC      drivers/input/touchscreen/atmel_mxt_ts.o
> drivers/input/touchscreen/atmel_mxt_ts.c:34:10: fatal error:
> dt-bindings/input/atmel_mxt_ts.h: No such file or directory
>     34 | #include <dt-bindings/input/atmel_mxt_ts.h>