Re: [PATCH] x86/boot/build: add cpustr.h to targets and remove clean-files

[Masahiro Yamada]

On Sat, Feb 15, 2020 at 3:33 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> Files in $(targets) are always cleaned up.
>
> Move the 'targets' assignment out of the ifdef and remove 'clean-files'.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>


This is not a big deal, but let me ping just in case
you missed it.





> ---
>
>  arch/x86/boot/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 012b82fc8617..050164ba3def 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -57,11 +57,10 @@ $(obj)/cpu.o: $(obj)/cpustr.h
>
>  quiet_cmd_cpustr = CPUSTR  $@
>        cmd_cpustr = $(obj)/mkcpustr > $@
> -targets += cpustr.h
>  $(obj)/cpustr.h: $(obj)/mkcpustr FORCE
>         $(call if_changed,cpustr)
>  endif
> -clean-files += cpustr.h
> +targets += cpustr.h
>
>  # ---------------------------------------------------------------------------
>
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada