Re: [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework

From: Richard Neumann
Date: Mon Mar 30 2020 - 04:33:55 EST


I took some time testing the patch series on my HP ENVY x360 13-
ag0005ng with a Ryzen 5 2500U.
On my machine the readout of register AMD_P2C_MSG3 (0x1068C) always
comes back as zero (0x0) and thusly activestatus will be zero as well.
Consequently the bistmask (0x0) will not match any sensor types.
I came up with a patch [1] on top of this patch series to add module
parameters to be able to statically enable the different sensors.
If I load the module with "force_accel=1" I get a working accelerometer
HID device and working screen rotation through iio-sensor-proxy. This
only works so far, if I boot the kernel with "amd_iommu=off", which
seems to be a general issue with this driver [2],[3].

[1] https://gist.githubusercontent.com/conqp/e8a0793406fbe7c9714f01f3078ea33a/raw/ac2de743e68d1dd90430e57cb28df8c1dc5d1098/amd-sfh.patch
[2] https://bbs.archlinux.org/viewtopic.php?id=253058
[3] https://bbs.archlinux.org/viewtopic.php?id=252815


Attachment: signature.asc
Description: This is a digitally signed message part