Re: [RFC] mm/page_alloc: Enumerate bad page reasons

[David Hildenbrand]

On 30.03.20 14:28, Anshuman Khandual wrote:
> 
> 
> On 03/30/2020 02:15 PM, David Hildenbrand wrote:
>> On 30.03.20 08:51, Anshuman Khandual wrote:
>>> Enumerate all existing bad page reasons which can be used in bad_page() for
>>> reporting via __dump_page(). Unfortunately __dump_page() cannot be changed.
>>> __dump_page() is called from dump_page() that accepts a raw string and is
>>> also an exported symbol that is currently being used from various generic
>>> memory functions and other drivers. This reduces code duplication while
>>> reporting bad pages.
>>
>> Yeah sounds nice, but "56 insertions(+), 20 deletions(-)" does not sound
>> so nice ... and the "code duplication" is actually "repeating strings".
> 
> But repeating strings in very similar functions dealing with bad page state
> is not bit suboptimal ?

Who cares? This is debug output.

-- 
Thanks,

David / dhildenb