Re: drivers/media/platform/davinci/vpfe_capture.c:883:20: warning: Redundant assignment

[Lad, Prabhakar]

Hello,

On Mon, Mar 30, 2020 at 4:53 PM David Binderman <dcb314@xxxxxxxxxxx> wrote:
>
> Hello there,
>
> linux-5.6/drivers/media/platform/davinci/vpfe_capture.c:883:20: warning: Redundant assignment of 'fmt->pixelformat' to itself. [selfAssignment]
>
> Source code is
>
>        fmt->pixelformat = fmt->pixelformat;
>
>
> Suggest code rework.
>
Fix for this is already in upstream with commit-id
5dbef6b3e09ffabf3b74d8d0fb230179d8fdc840
("media: davinci: fix incorrect pix_fmt assignment")

Cheers,
--Prabhakar

> Regards
>
> David Binderman