On Mon, 30 Mar 2020 09:45:30 -0700---snip
"John B. Wyatt IV" <jbwyatt4@xxxxxxxxx> wrote:
Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.
Issue reported by coccinelle (coccicheck).
Suggested-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx>
Suggested-by: Stefano Brivio <sbrivio@xxxxxxxxxx>
Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx>
Reviewed-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx>
Signed-off-by: John B. Wyatt IV <jbwyatt4@xxxxxxxxx>
---
v4: Move Suggested-by: Julia Lawall above seperator line.
Actually, as Julia didn't suggest this patch, the place where you had
this in v3 was the right one.
This section of hardware is controlled by mac80211 as is most of the driver.switch (priv->rf_type) {
case RF_AL2230:
@@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv)
case RF_VT3226:
case RF_VT3226D0:
case RF_VT3342A0:
- vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
- (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
+ ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
+ (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
Another thing that should be considered in this function is to restore
the previous hardware state on failures, but I think the way you're
handling this is possibly the safest, without hardware to test on.