Re: [RFC PATCH v2 3/3] KASAN: Port KASAN Tests to KUnit

[Patricia Alfonso]

On Thu, Mar 26, 2020 at 10:31 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
>
> On Thu, Mar 26, 2020 at 4:15 PM Patricia Alfonso
> <trishalfonso@xxxxxxxxxx> wrote:
> > > > > <kasan-dev@xxxxxxxxxxxxxxxx> wrote:
> > > > > >
> > > > > > Transfer all previous tests for KASAN to KUnit so they can be run
> > > > > > more easily. Using kunit_tool, developers can run these tests with their
> > > > > > other KUnit tests and see "pass" or "fail" with the appropriate KASAN
> > > > > > report instead of needing to parse each KASAN report to test KASAN
> > > > > > functionalities. All KASAN reports are still printed to dmesg.
> > > > > >
> > > > > > Stack tests do not work in UML so those tests are protected inside an
> > > > > > "#if IS_ENABLED(CONFIG_KASAN_STACK)" so this only runs if stack
> > > > > > instrumentation is enabled.
> > > > > >
> > > > > > copy_user_test cannot be run in KUnit so there is a separate test file
> > > > > > for those tests, which can be run as before as a module.
> > > > >
> > > > > Hi Patricia,
> > > > >
> > > > > FWIW I've got some conflicts applying this patch on latest linux-next
> > > > > next-20200324. There are some changes to the tests in mm tree I think.
> > > > >
> > > > > Which tree will this go through? I would be nice to resolve these
> > > > > conflicts somehow, but I am not sure how. Maybe the kasan tests
> > > > > changes are merged upstream next windows, and then rebase this?
> > > > >
> > > > > Also, how can I apply this for testing? I assume this is based on some
> > > > > kunit branch? which one?
> > > > >
> > > > Hmm... okay, that sounds like a problem. I will have to look into the
> > > > conflicts. I'm not sure which tree this will go through upstream; I
> > > > expect someone will tell me which is best when the time comes. This is
> > > > based on the kunit branch in the kunit documentation here:
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit
> > >
> > > I've checked out:
> > >
> > > commit 0476e69f39377192d638c459d11400c6e9a6ffb0 (HEAD, kselftest/kunit)
> > > Date:   Mon Mar 23 12:04:59 2020 -0700
> > >
> > > But the build still fails for me:
> > >
> > > mm/kasan/report.c: In function âkasan_update_kunit_statusâ:
> > > mm/kasan/report.c:466:6: error: implicit declaration of function
> > > âkunit_find_named_resourceâ [-Werror=implicit-function-declar]
> > >   466 |  if (kunit_find_named_resource(cur_test, "kasan_data")) {
> > >       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > mm/kasan/report.c:467:12: warning: assignment to âstruct
> > > kunit_resource *â from âintâ makes pointer from integer without a cas]
> > >   467 |   resource = kunit_find_named_resource(cur_test, "kasan_data");
> > >       |            ^
> > > mm/kasan/report.c:468:24: error: âstruct kunit_resourceâ has no member
> > > named âdataâ
> > >   468 |   kasan_data = resource->data;
> > >       |                        ^~
> > >
> > > What am I doing wrong?
> >
> > This patchset relies on another RFC patchset from Alan:
> > https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.maguire@xxxxxxxxxx/T/#t
> >
> > I thought I linked it in the commit message but it may only be in the
> > commit message for part 2/3. It should work with Alan's patchset, but
> > let me know if you have any trouble.
>
> Please push your state of code to some git repository, so that I can
> pull it. Github or gerrit or whatever.

Here's a Gerrit link: https://kunit-review.googlesource.com/c/linux/+/3513

-- 
Best,
Patricia Alfonso