Re: [PATCH bpf-next] bpf: lsm: Make BPF_LSM depend on BPF_EVENTS

From: Randy Dunlap
Date: Mon Mar 30 2020 - 17:01:26 EST


On 3/30/20 2:00 PM, Daniel Borkmann wrote:
> On 3/30/20 10:40 PM, KP Singh wrote:
>> From: KP Singh <kpsingh@xxxxxxxxxx>
>>
>> LSM and tracing programs share their helpers with bpf_tracing_func_proto
>> which is only defined (in bpf_trace.c) when BPF_EVENTS is enabled.
>>
>> Instead of adding __weak symbol, make BPF_LSM depend on
>> BPF_EVENTS so that both tracing and LSM programs can actually share
>> helpers.
>>
>> Signed-off-by: KP Singh <kpsingh@xxxxxxxxxx>
>> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Fixes: fc611f47f218 ("bpf: Introduce BPF_PROG_TYPE_LSM")
>
> Applied, thanks!

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

thanks.
--
~Randy