Re: [PATCH 2/4] clk: qcom: mmcc-msm8996: Properly describe GPU_GX gdsc
From: Rob Herring
Date: Mon Mar 30 2020 - 19:10:40 EST
On Sat, Mar 21, 2020 at 11:43:12AM -0700, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2020-03-20 22:16:12)
> > On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote:
> >
> > > Quoting Bjorn Andersson (2020-03-18 22:39:00)
> > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > > > index 85518494ce43..65d9aa790581 100644
> > > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > > > @@ -67,6 +67,10 @@ properties:
> > > > description:
> > > > Protected clock specifier list as per common clock binding
> > > >
> > > > + vdd_gfx-supply:
> > >
> > > Why not vdd-gfx-supply? What's with the underscore?
> > >
> >
> > The pad is named "VDD_GFX" in the datasheet and the schematics. I see
> > that we've started y/_/-/ in some of the newly added bindings, would you
> > prefer I follow this?
>
> If the datasheet has this then I guess it's fine. I'll wait for Rob to
> ack.
vddgfx or vdd-gfx.
Rob