RE: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs

From: Kammela, Gayatri
Date: Mon Mar 30 2020 - 19:22:10 EST


> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Monday, March 30, 2020 10:25 AM
> To: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Cc: Kammela, Gayatri <gayatri.kammela@xxxxxxxxx>; Zhang, Rui
> <rui.zhang@xxxxxxxxx>; Linux PM <linux-pm@xxxxxxxxxxxxxxx>; Platform
> Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; Darren Hart
> <dvhart@xxxxxxxxxxxxx>; Alex Hung <alex.hung@xxxxxxxxxxxxx>; Daniel
> Lezcano <daniel.lezcano@xxxxxxxxxx>; Amit Kucheria
> <amit.kucheria@xxxxxxxxxxxxx>; Westerberg, Mika
> <mika.westerberg@xxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>;
> Prestopine, Charles D <charles.d.prestopine@xxxxxxxxx>; 5 . 6+
> <stable@xxxxxxxxxxxxxxx>; Pandruvada, Srinivas
> <srinivas.pandruvada@xxxxxxxxx>; Wysocki, Rafael J
> <rafael.j.wysocki@xxxxxxxxx>
> Subject: Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
>
> On Mon, Mar 30, 2020 at 06:43:35PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
> > <gayatri.kammela@xxxxxxxxx> wrote:
>
> > > - {"INT1044"},
> > > - {"INT1047"},
> > > + {"INTC1040"},
> > > + {"INTC1043"},
> > > + {"INTC1044"},
> > > + {"INTC1047"},
> > > {"INT3400"},
> > > {"INT3401", INT3401_DEVICE},
> > > {"INT3402"},
> > > --
> >
> > I can take this along with the other two patches in the series if that
> > is fine by Andy and Rui.
>
> One nit is to fix the ordering to be alphanumeric or close enough (I admit in
> some cases it might require unneeded churn) to that.
Thanks Andy and Rafael! Should I send v3 for this series with right ordering this time?
>
> Otherwise,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> --
> With Best Regards,
> Andy Shevchenko
>