Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2

[Marek Szyprowski]

Hi Paul,

On 2020-03-18 15:25, Paul Cercueil wrote:
>>> Â+ÂÂÂ };
>>> Â+
>>> Â+ÂÂÂ tsp_reg: regulator-1 {
>>> Â+ÂÂÂÂÂÂÂ compatible = "regulator-fixed";
>>> Â+ÂÂÂÂÂÂÂ regulator-name = "TSP_FIXED_VOLTAGES";
>>> Â+ÂÂÂÂÂÂÂ regulator-min-microvolt = <3300000>;
>>> Â+ÂÂÂÂÂÂÂ regulator-max-microvolt = <3300000>;
>>> Â+ÂÂÂÂÂÂÂ gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>;
>>> Â+ÂÂÂÂÂÂÂ startup-delay-us = <70000>;
>>> Â+ÂÂÂÂÂÂÂ enable-active-high;
>>> Â+ÂÂÂÂÂÂÂ regulator-boot-on;
>>> Â+ÂÂÂÂÂÂÂ regulator-always-on;
>>
>> always-on and boot-on should not be needed. You have a consumer for this
>> regulator.
>
> About this: the touchscreen driver does not use a regulator, so I 
> believe that's why these properties were here.
>
> I sent patches upstream to address the issue: 
> https://lkml.org/lkml/2020/3/15/94
>
> I believe this means I cannot merge the i9100 devicetree until it is 
> acked.

One more information - similar change has been already posted, but it 
looks it got lost then: https://patchwork.kernel.org/patch/10550903/

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland