Re: [PATCH 5.5 102/170] scripts/dtc: Remove redundant YYLOC global declaration

[Greg Kroah-Hartman]

On Tue, Mar 31, 2020 at 01:45:09PM +0200, Dirk Müller wrote:
> Hi Greg,
> 
> >> $ sed -i 's;scripts/dtc/dtc-lexer.l;scripts/dtc/dtc-lexer.lex.c_shipped;g' \
> >> queue-{4.4,4.9,4.14}/scripts-dtc-remove-redundant-yyloc-global-declaration.patch
> >> If you would prefer a set of patches, let me know.
> > Should I just drop the patch from 4.4, 4.9, and 4.14 instead?
> 
> as the original author of the patch, I am not sure why it was backported to the LTS releases (unless enablement for gcc 10.x or
> other new toolchains is a requirement, which I'm not aware of). 

Keeping the older kernels building with newer compilers is something
that we do.  It's needed as our build systems "age-out" the older
compilers a lot :)

> However I think the sed above on the *patch* means that the patch will *only* modify the generated sources, not the input sources. I think
> it would be better to patch both *input* and *generated* sources, or backport the generate-at-runtime patch as well (which might be
> even further outside the stable policy). 

What do you mean by "input sources" here?

> Not knowing why it was backported, I would suggest to just dequeue the patch from the older trees. 

If I drop it for now, I'll have to add it back when gcc10 is pushed out
to my build systems and laptops :(

thanks,

greg k-h