Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Mon, Mar 30, 2020 at 10:32 PM Lukas Wunner <lukas@xxxxxxxxx> wrote:
> On Tue, Mar 31, 2020 at 05:14:58AM +0200, Lukas Wunner wrote:
> > On Mon, Mar 30, 2020 at 03:53:29PM -0500, Bjorn Helgaas wrote:
> > > On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote> > In commit
> > > >
> > > >   fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
> > > >
> > > > Fixes tag
> > > >
> > > >   Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > > >
> > > > has these problem(s):
> > > >
> > > >   - Subject does not match target commit subject
> > > >     Just use
> > > >         git log -1 --format='Fixes: %h ("%s")'
> > > >
> > > > Did you mean
> > > >
> > > > (probably not :-))
> > > > Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
> > > >
> > > > or
> > > >
> > > > Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > >
> > > Fixed, thanks!
> >
> > Ugh, sorry about that.
> >
> > In case you're not aware, it's only fixed on your next branch,
> > not on the pci/hotplug branch.
>
> Also, the incorrect commit hash is repeated further up in the commit
> message:  "This flag, which was introduced by commit 54ecb8f7028c"

Thanks, I fixed that, too, and pushed my -next branch.  It's fixed on
my local pci/hotplug branch, but I didn't bother pushing that branch
because it doesn't need to be build-tested and it doesn't matter for
any future hotplug patches.

Bjorn