Re: [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller

[Boris Brezillon]

On Wed, 1 Apr 2020 02:07:58 +0800
Weijie Gao <weijie.gao@xxxxxxxxxxxx> wrote:

> This patch adds NAND flash controller driver for MediaTek MT7621 SoC.
> 
> The NAND flash controller is similar with controllers described in
> mtk_nand.c, except that the controller from MT7621 doesn't support DMA
> transmission, and some registers' offset and fields are different.
> 

Please don't duplicate driver the driver for those minor differences:
use regmap/reg_field to abstract reg field positions and make the DMA
optional.