Re: [PATCH] compiler.h: fix error in BUILD_BUG_ON() reporting

From: Rasmus Villemoes
Date: Tue Mar 31 2020 - 14:56:58 EST


On 31/03/2020 20.20, Joe Perches wrote:
> On Tue, 2020-03-31 at 13:26 +0200, Vegard Nossum wrote:

>> #define compiletime_assert(condition, msg) \
>> - _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>> + _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> This might be better using something like __LINE__ ## _ ## __COUNTER__
>
> as line # is somewhat useful to identify the specific assert in a file.
>

Eh, if the assert fires, doesn't the compiler's diagnostics already
contain all kinds of location information?

Rasmus