Re: [PATCH 1/2] of: gpio unittest kfree() wrong object

From: Rob Herring
Date: Tue Mar 31 2020 - 17:57:45 EST


On Wed, 25 Mar 2020 20:45:30 -0500, frowand.list@xxxxxxxxx wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> kernel test robot reported "WARNING: held lock freed!" triggered by
> unittest_gpio_remove(). unittest_gpio_remove() was unexpectedly
> called due to an error in overlay tracking. The remove had not
> been tested because the gpio overlay removal tests have not been
> implemented.
>
> kfree() gdev instead of pdev.
>
> Fixes: f4056e705b2e ("of: unittest: add overlay gpio test to catch gpio hog problem")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> ---
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks.

Rob