Re: [PATCH] clocksource: Add debugfs support

[Thierry Reding]

On Wed, Apr 01, 2020 at 01:01:49AM +0200, Thomas Gleixner wrote:
> Thierry Reding <thierry.reding@xxxxxxxxx> writes:
> > On Wed, Apr 01, 2020 at 12:06:37AM +0200, Thomas Gleixner wrote:
> >> It does not provide any information about the clocksource, it provides
> >> an interface to read the counter - nothing else.
> >
> > The counter is part of the information about a clocksource, isn't it?
> 
> Sorry to be pedantic, but no. Information about a clocksource is the
> name, the type, the frequency, bitwidth etc.
> 
> The counter file is not providing information about the
> clocksource. It's exposing an accessor to the clocksource itself.

Okay, fair enough.

> > I can also add some information about what I intend to use this for,
> > though it'll be a bit boring because I really only want this as a way
> > of testing that I'm reading from the right registers and that these
> > counters are running. A debugfs interface seemed like a better and more
> > widely useful way to achieve that than implementing some one-off hack to
> > poll those registers.
> 
> But how much value has this interface beyond the 'hack a driver for a
> new clocksource' experience?
> 
> To me none, but that might be my personal skewed view.

No, that's the only intended purpose. I just thought that would be nicer
than everyone having to write their own debug messages to do the same
thing.

If nobody else thinks this is useful I'll just stash it somewhere in
case I ever need it again.

Thierry

Attachment: signature.asc
Description: PGP signature