Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments

From: William Kucharski
Date: Sun Apr 05 2020 - 16:49:57 EST


That's fine.

One could still argue size should be sanitized earlier when start and end
are, but it's a nit either way (though size is used before it's checked,
it's not in any way that could fail with bad results.)

-- Bill

> On Apr 5, 2020, at 1:21 PM, Uladzislau Rezki <urezki@xxxxxxxxx> wrote:
>
> On Sun, Apr 05, 2020 at 07:23:15PM +0200, Uladzislau Rezki wrote:
> Sorry, was thinking about one place showed different one. Here we go:
>
> <snip>
> /* Check the "vend" restriction. */
> if (nva_start_addr + size > vend)
> return vend;
> <snip>
>
> --
> Vlad Rezki