Re: [PATCH 3/3] iio: adc: Add support for PMIC7 ADC

[Jishnu Prakash]

Hi Jonathan,

On 3/28/2020 10:34 PM, Jonathan Cameron wrote:
> On Tue, 24 Mar 2020 21:14:10 +0530
> Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote:
>
> > The ADC architecture on PMIC7 is changed as compared to PMIC5. The
> > major change from PMIC5 is that all SW communication to ADC goes through
> > PMK8350, which communicates with other PMICs through PBS when the ADC
> > on PMK8350 works in master mode. The SID register is used to identify the
> > PMICs with which the PBS needs to communicate. Add support for the same.
> >
> > In addition, add definitions for ADC channels and virtual channel
> > definitions per PMIC, to be used by ADC clients for PMIC7.
> >
> > Signed-off-by: Jishnu Prakash <jprakash@xxxxxxxxxxxxxx>
> A few additions from me.
>
> > ---
> ...
>
> I'll address your comments in the next post.