Re: [PATCH] perf stat: Fix no metric header if --per-socket and --metric-only set
From: Arnaldo Carvalho de Melo
Date: Mon Apr 06 2020 - 10:12:13 EST
Em Fri, Apr 03, 2020 at 11:45:00AM +0200, Jiri Olsa escreveu:
> On Wed, Apr 01, 2020 at 02:02:26AM +0800, Jin Yao wrote:
> > We received a report that was no metric header displayed if --per-socket
> > and --metric-only were both set.
> >
> > It's hard for script to parse the perf-stat output. This patch fixes this
> > issue.
> >
> > Before:
> >
> > root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket
> > ^C
> > Performance counter stats for 'system wide':
> >
> > S0 8 2.6
> >
> > 2.215270071 seconds time elapsed
> >
> > root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket -I1000
> > # time socket cpus
> > 1.000411692 S0 8 2.2
> > 2.001547952 S0 8 3.4
> > 3.002446511 S0 8 3.4
> > 4.003346157 S0 8 4.0
> > 5.004245736 S0 8 0.3
> >
> > After:
> >
> > root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket
> > ^C
> > Performance counter stats for 'system wide':
> >
> > CPI
> > S0 8 2.1
> >
> > 1.813579830 seconds time elapsed
> >
> > root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket -I1000
> > # time socket cpus CPI
> > 1.000415122 S0 8 3.2
> > 2.001630051 S0 8 2.9
> > 3.002612278 S0 8 4.3
> > 4.003523594 S0 8 3.0
> > 5.004504256 S0 8 3.7
> >
> > Signed-off-by: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Thanks, applied.
- Arnaldo