Re: [PATCH] vdpa-sim: depend on HAS_DMA

From: Jason Wang
Date: Mon Apr 06 2020 - 10:13:10 EST



On 2020/4/6 äå10:02, Michael S. Tsirkin wrote:
On Mon, Apr 06, 2020 at 06:09:27AM -0700, Christoph Hellwig wrote:
Pleae just drop the code - we should not add new drivers with custom
DMA ops.
I'm not sure there's another way to do this: this not a driver, it's a
software emulator that pretends to be an actual device. We can't
have the platform supply DMA ops here since the platform is a regular
x86 or whatever.


Yes, actually vdpa-sim does not depends on HAS_DMA. Maybe we can do shortcut like dev->dma_ops = vdpasim_dma_ops;

Thanks