Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp: Add ipq8074 usb dt bindings

[Bjorn Andersson]

On Fri 10 Apr 11:29 PDT 2020, Sivaprakash Murugesan wrote:

> Add ipq8074 qmp phy device compatible for usb super speed usb support.
> 
> Signed-off-by: Sivaprakash Murugesan <sivaprak@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 18a8985..d60c845 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -18,6 +18,7 @@ properties:
>    compatible:
>      enum:
>        - qcom,ipq8074-qmp-pcie-phy
> +      - qcom,ipq8074-qmp-usb-phy

I believe you're missing a "3" here.

Regards,
Bjorn

>        - qcom,msm8996-qmp-pcie-phy
>        - qcom,msm8996-qmp-ufs-phy
>        - qcom,msm8996-qmp-usb3-phy
> @@ -166,6 +167,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,ipq8074-qmp-usb3-phy
>                - qcom,msm8996-qmp-usb3-phy
>                - qcom,msm8998-qmp-pcie-phy
>                - qcom,msm8998-qmp-usb3-phy
> -- 
> 2.7.4
>