Re: [PATCH -next] bpf: remove set but not used variable 'dst_known'

From: maowenan
Date: Tue Apr 14 2020 - 21:37:31 EST


On 2020/4/15 6:05, Song Liu wrote:
>
>
>> On Apr 13, 2020, at 4:37 AM, Mao Wenan <maowenan@xxxxxxxxxx> wrote:
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> kernel/bpf/verifier.c:5603:18: warning: variable âdst_knownâ
>> set but not used [-Wunused-but-set-variable]
>>
>> It is not used since commit f1174f77b50c ("bpf/verifier:
>> rework value tracking")
>
> The fix makes sense. But I think f1174f77b50c introduced dst_known,
> so this statement is not accurate.
>
thanks for review, yes, f1174f77b50c introduced dst_known, and below commit
doesn't deference variable dst_known. So I send v2 later?
3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking")

>>
>> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
>