Re: [PATCH -next] bpf: remove set but not used variable 'dst_known'

[Song Liu]

> On Apr 14, 2020, at 6:37 PM, maowenan <maowenan@xxxxxxxxxx> wrote:
> 
> On 2020/4/15 6:05, Song Liu wrote:
>> 
>> 
>>> On Apr 13, 2020, at 4:37 AM, Mao Wenan <maowenan@xxxxxxxxxx> wrote:
>>> 
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>> 
>>> kernel/bpf/verifier.c:5603:18: warning: variable âdst_knownâ
>>> set but not used [-Wunused-but-set-variable]
>>> 
>>> It is not used since commit f1174f77b50c ("bpf/verifier:
>>> rework value tracking")
>> 
>> The fix makes sense. But I think f1174f77b50c introduced dst_known, 
>> so this statement is not accurate. 
>> 
> thanks for review, yes, f1174f77b50c introduced dst_known, and below commit
> doesn't deference variable dst_known. So I send v2 later?
> 3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking")

I don't think we need to back port this to stable. So it is OK not to 
include Fixes tag. We can just remove this statement in the commit log.

bpf-next is not open yet. Please send v2 when bpf-next is open. 

Thanks,
Song