Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled

From: Markus Elfring
Date: Thu Apr 16 2020 - 02:01:10 EST


> to a crash when we access vm_mm(its offset is 0x40) later in

Would the text variant ââ vm_mm (its ââ be a bit nicer?


â
> +++ b/mm/ksm.c
> @@ -2112,8 +2112,15 @@ static void cmp_and_merge_page(struct page *page, struct rmap_item *rmap_item)
â
> + if (vma)
> + err = try_to_merge_one_page(vma, page,
> + ZERO_PAGE(rmap_item->address));

Can the parameter alignment trigger further software development considerations
for such a function call?

Regards,
Markus