Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled

[Markus Elfring]

â
>> +++ b/mm/ksm.c
>> @@ -2112,8 +2112,15 @@ static void cmp_and_merge_page(struct page *page, struct rmap_item *rmap_item)
â
>> +		if (vma)
>> +			err = try_to_merge_one_page(vma, page,
>> +					ZERO_PAGE(rmap_item->address));
>> +		else
>> +			/**
>> +			 * If the vma is out of date, we do not need to
>> +			 * continue.
>> +			 */
>> +			err = 0;
>>  		up_read(&mm->mmap_sem);
â
> It's conventional to put braces around multi-line blocks such as this.

Are there different views to consider around the usage of single statements
together with curly brackets in if branches?

Regards,
Markus