Re: [PATCH V2 1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema

[Marco Felsch]

On 20-04-16 09:48, Anson Huang wrote:
> Hi, Marco
> 
> > Subject: Re: [PATCH V2 1/5] dt-bindings: clock: Convert i.MX6Q clock to
> > json-schema
> > 
> > Hi Anson,
> > 
> > On 20-04-16 14:39, Anson Huang wrote:
> > 
> > ...
> > 
> > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > new file mode 100644
> > > index 0000000..1c6e600
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > @@ -0,0 +1,66 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr
> > ee.org%2Fschemas%2Fclock%2Fimx6q-clock.yaml%23&data=02%7C01%
> > 7Canson.huang%40nxp.com%7Ca840fd5be8c94d4d950608d7e1ea16a2%7C6
> > 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637226267845578228&
> > amp;sdata=Iw1CkVBMqw3m6sox6C3khcMy0BHNCQ9v2k72q3CM6Xs%3D&a
> > mp;reserved=0
> > > +$schema:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr
> > ee.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Canson.hu
> > ang%40nxp.com%7Ca840fd5be8c94d4d950608d7e1ea16a2%7C686ea1d3bc2
> > b4c6fa92cd99c5c301635%7C0%7C1%7C637226267845578228&sdata=P
> > Be2CEoDdMo9I1m3DHbITCyYxB4GF%2FigP%2FNd7YCopCQ%3D&reserve
> > d=0
> > > +
> > > +title: Clock bindings for Freescale i.MX6 Quad
> > > +
> > > +maintainers:
> > > +  - Anson Huang <Anson.Huang@xxxxxxx>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: fsl,imx6q-ccm
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  interrupts:
> > > +    maxItems: 2
> > 
> > IMHO I would force them to have exactly two so we need
> > minItems: 2 too here.
> 
> Actually, those 2 interrupts are NOT necessary for some platforms, such as i.MX platforms
> do NOT enable them at all, so is it OK to force them to be '2' here?

Why do we list them as required if they are not required? Currently all
5 platforms adding both irqs so this won't break anything here.

Regards,
  Marco

> Thanks,
> Anson