Re: [PATCH v3 1/5] arch/x86/kvm: Refactor l1d flush lifecycle management

[Singh, Balbir]

On Fri, 2020-04-17 at 14:57 +0200, Thomas Gleixner wrote:
> CAUTION: This email originated from outside of the organization. Do not
> click links or open attachments unless you can confirm the sender and know
> the content is safe.
> 
> 
> 
> Balbir Singh <sblbir@xxxxxxxxxx> writes:
> >  #include <asm-generic/cacheflush.h>
> >  #include <asm/special_insns.h>
> > 
> > +#define L1D_CACHE_ORDER 4
> 
> Newline between constants and declarations please
> 
> >  void clflush_cache_range(void *addr, unsigned int size);
> > +void *alloc_l1d_flush_pages(void);
> > +void cleanup_l1d_flush_pages(void *l1d_flush_pages);
> 
> Can we please have a consistent name space prefix?
> 
> l1d_flush_*()
> 

I used l1d_flush_pages as a noun and then a verb in front of it to denote
action alloc_l1d_flush_pages(), happy to change it over, don't feel to
strongly about it.

Balbir