Re: [PATCH] mfd: asic3: Add error checking return in asic3_mfd_probe()

From: Markus Elfring
Date: Sun Apr 19 2020 - 07:19:19 EST


> In the function asic3_mfd_probe(), when get resource or irq
> failed, the value returned just detected and debug error message,
> but there were no error checking return. So add the right error
> checking return.

I suggest to improve the commit message.
Would you like to adjust the patch subject?


> And remove the redundant 'ret = 0'.

I propose to reconsider this interpretation of the source code here.
How do you think about to move the mentioned statement into an else branch
at the end?

Regards,
Markus