Re: [PATCH] mfd: asic3: Add error checking return in asic3_mfd_probe()

[Lee Jones]

On Sun, 19 Apr 2020, Markus Elfring wrote:

> > In the function asic3_mfd_probe(), when get resource or irq
> > failed, the value returned just detected and debug error message,
> > but there were no error checking return. So add the right error
> > checking return.
> 
> I suggest to improve the commit message.
> Would you like to adjust the patch subject?
> 
> 
> > And remove the redundant 'ret = 0'.
> 
> I propose to reconsider this interpretation of the source code here.
> How do you think about to move the mentioned statement into an else branch
> at the end?

Could you please fix your mailer.

If you do not, your replies will be lost/discounted!

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog