Re: [PATCH v3 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.

From: Andy Shevchenko
Date: Mon Apr 20 2020 - 20:44:16 EST


On Mon, Apr 20, 2020 at 11:44 AM Mathieu Othacehe <m.othacehe@xxxxxxxxx> wrote:
>
> Add sampling frequency support for ambient light and proximity data on
> VCNL4010 and VCNL4020 chips.

...

> +static struct attribute *vcnl4010_attributes[] = {
> + &iio_const_attr_in_illuminance_sampling_frequency_available.dev_attr.attr,
> + &iio_const_attr_in_proximity_sampling_frequency_available.dev_attr.attr,

> + NULL,

No comma for terminator line.

> +};
...

> +static const struct attribute_group vcnl4010_attribute_group = {
> + .attrs = vcnl4010_attributes

Leave comma at the end in struct member definition.

> +};

--
With Best Regards,
Andy Shevchenko