Re: [PATCH v3 02/13] powerpc/40x: Rework 40x PTE access and TLB miss

From: kbuild test robot
Date: Mon Apr 20 2020 - 20:47:49 EST

Hi Christophe,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on robh/for-next char-misc/char-misc-testing tip/locking/core linus/master v5.7-rc2 next-20200420]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/Modernise-powerpc-40x/20200414-185156
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-ppc40x_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

arch/powerpc/mm/nohash/40x.c: In function 'mmu_mapin_ram':
>> arch/powerpc/mm/nohash/40x.c:107:3: error: expected ',' or ';' before 'pmdp'
107 | pmdp = pmd_ptr_k(v);
| ^~~~

vim +107 arch/powerpc/mm/nohash/40x.c

14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 90
14e609d693ef67 arch/powerpc/mm/40x_mmu.c Christophe Leroy 2019-02-21 91 unsigned long __init mmu_mapin_ram(unsigned long base, unsigned long top)
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 92 {
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 93 unsigned long v, s, mapped;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 94 phys_addr_t p;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 95
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 96 v = KERNELBASE;
99c62dd773797b arch/powerpc/mm/40x_mmu.c Kumar Gala 2008-04-16 97 p = 0;
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 98 s = total_lowmem;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 99
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 100 if (__map_without_ltlbs)
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 101 return 0;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 102
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 103 while (s >= LARGE_PAGE_SIZE_16M) {
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 104 pmd_t *pmdp;
682f715365c25b arch/powerpc/mm/nohash/40x.c Christophe Leroy 2020-04-14 105 unsigned long val = p | _PMD_SIZE_16M | _PAGE_EXEC | _PAGE_RW
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 106
0b1c524caaae24 arch/powerpc/mm/nohash/40x.c Christophe Leroy 2020-01-09 @107 pmdp = pmd_ptr_k(v);
f281b5d50c87ec arch/powerpc/mm/40x_mmu.c Aneesh Kumar K.V 2015-12-01 108 *pmdp++ = __pmd(val);
f281b5d50c87ec arch/powerpc/mm/40x_mmu.c Aneesh Kumar K.V 2015-12-01 109 *pmdp++ = __pmd(val);
f281b5d50c87ec arch/powerpc/mm/40x_mmu.c Aneesh Kumar K.V 2015-12-01 110 *pmdp++ = __pmd(val);
f281b5d50c87ec arch/powerpc/mm/40x_mmu.c Aneesh Kumar K.V 2015-12-01 111 *pmdp++ = __pmd(val);
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 112
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 113 v += LARGE_PAGE_SIZE_16M;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 114 p += LARGE_PAGE_SIZE_16M;
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 115 s -= LARGE_PAGE_SIZE_16M;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 116 }
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 117
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 118 while (s >= LARGE_PAGE_SIZE_4M) {
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 119 pmd_t *pmdp;
682f715365c25b arch/powerpc/mm/nohash/40x.c Christophe Leroy 2020-04-14 120 unsigned long val = p | _PMD_SIZE_4M | _PAGE_EXEC | _PAGE_RW;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 121
0b1c524caaae24 arch/powerpc/mm/nohash/40x.c Christophe Leroy 2020-01-09 122 pmdp = pmd_ptr_k(v);
f281b5d50c87ec arch/powerpc/mm/40x_mmu.c Aneesh Kumar K.V 2015-12-01 123 *pmdp = __pmd(val);
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 124
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 125 v += LARGE_PAGE_SIZE_4M;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 126 p += LARGE_PAGE_SIZE_4M;
bd942ba3db60d3 arch/powerpc/mm/40x_mmu.c Grant Likely 2007-10-31 127 s -= LARGE_PAGE_SIZE_4M;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 128 }
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 129
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 130 mapped = total_lowmem - s;
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 131
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 132 /* If the size of RAM is not an exact power of two, we may not
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 133 * have covered RAM in its entirety with 16 and 4 MiB
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 134 * pages. Consequently, restrict the top end of RAM currently
95f72d1ed41a66 arch/powerpc/mm/40x_mmu.c Yinghai Lu 2010-07-12 135 * allocable so that calls to the MEMBLOCK to allocate PTEs for "tail"
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 136 * coverage with normal-sized pages (or other reasons) do not
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 137 * attempt to allocate outside the allowed range.
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 138 */
cd3db0c4ca3d23 arch/powerpc/mm/40x_mmu.c Benjamin Herrenschmidt 2010-07-06 139 memblock_set_current_limit(mapped);
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 140
5907630ffc2b2d arch/powerpc/mm/40x_mmu.c Grant Erickson 2008-10-29 141 return mapped;
14cf11af6cf608 arch/powerpc/mm/4xx_mmu.c Paul Mackerras 2005-09-26 142 }
cd3db0c4ca3d23 arch/powerpc/mm/40x_mmu.c Benjamin Herrenschmidt 2010-07-06 143

:::::: The code at line 107 was first introduced by commit
:::::: 0b1c524caaae2428b20e714297243e5551251eb5 powerpc/32: refactor pmd_offset(pud_offset(pgd_offset...

:::::: TO: Christophe Leroy <christophe.leroy@xxxxxx>
:::::: CC: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip