Re: [PATCH v7 09/12] ARM: dts: sun6i: a31: add sgx gpu child node

[Paul Cercueil]

Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller 
<hns@xxxxxxxxxxxxx> a écrit :
> From: Philipp Rossak <embed3d@xxxxxxxxx>
>
> We are adding the devicetree binding for the PVR-SGX-544-115 gpu.
>
> This driver is currently under development in the openpvrsgx-devgroup.
> Right now the full binding is not figured out, so we provide here a
> placeholder. It will be completed as soon as there is a demo 
> available.
>
> The currently used binding that is used during development is more
> complete and was already verifyed by loading the kernelmodule 
> successful.
>
> Signed-off-by: Philipp Rossak <embed3d@xxxxxxxxx>
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi 
> b/arch/arm/boot/dts/sun6i-a31.dtsi
> index f3425a66fc0a..933a825bf460 100644
> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> @@ -1417,5 +1417,16 @@ p2wi: i2c@1f03400 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  		};
> +
> +		gpu: gpu@1c400000 {
> +			compatible = "allwinner,sun8i-a31-sgx544-115",
> +				     "img,sgx544-115", "img,sgx544";
> +			reg = <0x01c40000 0x10000>;
> +			/*
> +			 * This node is currently a placeholder for the gpu.
> +			 * This will be completed when a full demonstration
> +			 * of the openpvrsgx driver is available for this board.
> +			 */

This node doesn't have clocks, so I don't see how it'd work.

Better delay the introduction of the GPU node for this board until you 
know it works.

-Paul

> +		};
>  	};
>  };
> --
> 2.25.1