Re: [PATCH v7 09/12] ARM: dts: sun6i: a31: add sgx gpu child node

[Philipp Rossak]

Hi Paul,

On 26.04.20 14:53, Paul Cercueil wrote:
> Le ven. 24 avril 2020 Ã 22:34, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> 
> a Ãcrit :
> > From: Philipp Rossak <embed3d@xxxxxxxxx>
> >
> > We are adding the devicetree binding for the PVR-SGX-544-115 gpu.
> >
> > This driver is currently under development in the openpvrsgx-devgroup.
> > Right now the full binding is not figured out, so we provide here a
> > placeholder. It will be completed as soon as there is a demo available.
> >
> > The currently used binding that is used during development is more
> > complete and was already verifyed by loading the kernelmodule successful.
> >
> > Signed-off-by: Philipp Rossak <embed3d@xxxxxxxxx>
> > Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> > ---
> > Âarch/arm/boot/dts/sun6i-a31.dtsi | 11 +++++++++++
> > Â1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi 
> > b/arch/arm/boot/dts/sun6i-a31.dtsi
> > index f3425a66fc0a..933a825bf460 100644
> > --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> > @@ -1417,5 +1417,16 @@ p2wi: i2c@1f03400 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂ #address-cells = <1>;
> > ÂÂÂÂÂÂÂÂÂÂÂÂ #size-cells = <0>;
> > ÂÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ gpu: gpu@1c400000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "allwinner,sun8i-a31-sgx544-115",

looks like a copy paste error from my side this should be 
allwinner,sun6i-a31-sgx544-115

> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "img,sgx544-115", "img,sgx544";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x01c40000 0x10000>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ /*
> > +ÂÂÂÂÂÂÂÂÂÂÂÂ * This node is currently a placeholder for the gpu.
> > +ÂÂÂÂÂÂÂÂÂÂÂÂ * This will be completed when a full demonstration
> > +ÂÂÂÂÂÂÂÂÂÂÂÂ * of the openpvrsgx driver is available for this board.
> > +ÂÂÂÂÂÂÂÂÂÂÂÂ */
>
> This node doesn't have clocks, so I don't see how it'd work.
>
> Better delay the introduction of the GPU node for this board until you 
> know it works.
>
> -Paul
This was already discuss in an earlier version that series that this 
should be delayed.

I will send a follow up patch series, as soon as I mainlined an other 
driver that I'm working on, which is required to properly describe the gpu.

Cheers
Philipp