Re: [PATCH V1 01/10] arch/kmap: Remove BUG_ON()

From: Christoph Hellwig
Date: Fri May 01 2020 - 04:36:08 EST


On Thu, Apr 30, 2020 at 01:38:36PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Replace the use of BUG_ON(in_interrupt()) in the kmap() and kunmap()
> in favor of might_sleep().
>
> Besides the benefits of might_sleep(), this normalizes the
> implementations such that they can be made generic in subsequent
> patches.
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>